Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9487] [cherry-pick] Various Trigger.may_lose_data fixes #15745

Merged
merged 7 commits into from Oct 19, 2021

Conversation

ibzib
Copy link
Contributor

@ibzib ibzib commented Oct 18, 2021

R: @zhoufek

cherry-pick #15603 onto release branch.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #15745 (8837e1d) into release-2.34.0 (f9c1007) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.34.0   #15745      +/-   ##
==================================================
+ Coverage           83.49%   83.50%   +0.01%     
==================================================
  Files                 445      445              
  Lines               61195    61186       -9     
==================================================
- Hits                51096    51095       -1     
+ Misses              10099    10091       -8     
Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/trigger.py 89.86% <100.00%> (+0.47%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.39% <0.00%> (-0.13%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.39% <0.00%> (ø)
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.16% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 96.26% <0.00%> (+2.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2876f6b...8837e1d. Read the comment docs.

@zhoufek
Copy link
Contributor

zhoufek commented Oct 18, 2021

LGTM

@ibzib ibzib merged commit 9c729f2 into apache:release-2.34.0 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants