Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]De-javafy the Python Metrics API #15919

Closed
wants to merge 1 commit into from

Conversation

AnandInguva
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #15919 (9c7cc58) into master (213bb78) will increase coverage by 9.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15919      +/-   ##
==========================================
+ Coverage   74.60%   83.62%   +9.02%     
==========================================
  Files         640      445     -195     
  Lines       80839    61384   -19455     
==========================================
- Hits        60307    51331    -8976     
+ Misses      19563    10053    -9510     
+ Partials      969        0     -969     
Impacted Files Coverage Δ
...hon/apache_beam/examples/wordcount_with_metrics.py 25.00% <0.00%> (-0.81%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.14% <0.00%> (-0.50%) ⬇️
sdks/python/apache_beam/runners/common.py 89.98% <0.00%> (-0.30%) ⬇️
sdks/python/apache_beam/transforms/util.py 95.86% <0.00%> (-0.17%) ⬇️
sdks/go/pkg/beam/transforms/stats/min_switch.go
sdks/go/pkg/beam/core/graph/scope.go
sdks/go/pkg/beam/core/runtime/graphx/dataflow.go
sdks/go/pkg/beam/core/runtime/exec/translate.go
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213bb78...9c7cc58. Read the comment docs.

@AnandInguva
Copy link
Contributor Author

Run Python 3.8 PostCommit

@robertwb
Copy link
Contributor

Is this a proposal for what an API could look like?

@AnandInguva
Copy link
Contributor Author

Is this a proposal for what an API could look like?

@robertwb Yes, it would be a new API for metrics. We need to write the metrics API in pythonic way

@aaltay
Copy link
Member

aaltay commented Dec 3, 2021

If this is work in progress, could you add WIP / draft to the subject please?

@AnandInguva AnandInguva marked this pull request as draft December 4, 2021 10:33
@AnandInguva AnandInguva changed the title [BEAM-3046] De-javafy the Python Metrics API [DO NOT MERGE]De-javafy the Python Metrics API Dec 15, 2021
@AnandInguva AnandInguva deleted the metrics_api branch December 16, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants