Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12829] Never copy .gogradle/** for Python. #16060

Merged
merged 1 commit into from Nov 29, 2021

Conversation

tvalentyn
Copy link
Contributor

Cherry-picks #16059 to the release branch.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@tvalentyn
Copy link
Contributor Author

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'm not so cavalier to recommend merging it until the python tests pass.

@tvalentyn
Copy link
Contributor Author

Let's cast some spells.

@tvalentyn
Copy link
Contributor Author

Run Release Gradle Build

@tvalentyn
Copy link
Contributor Author

Run Python PreCommit

@lostluck
Copy link
Contributor

The Python Precommit failure looks unrelated. The precommit passed in the PR to master. (now merged).

Now to wait for the Release build....

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #16060 (9621626) into release-2.35.0 (11b03b8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.35.0   #16060      +/-   ##
==================================================
- Coverage           83.62%   83.61%   -0.01%     
==================================================
  Files                 445      445              
  Lines               61355    61355              
==================================================
- Hits                51306    51304       -2     
- Misses              10049    10051       +2     
Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 87.80% <0.00%> (-4.88%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.41% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/transforms/util.py 96.02% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/internal/metrics/metric.py 91.00% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3a8c4...9621626. Read the comment docs.

@lostluck
Copy link
Contributor

Huzzah! Success :D

@tvalentyn tvalentyn merged commit 3cbeaa0 into apache:release-2.35.0 Nov 29, 2021
@tvalentyn tvalentyn deleted the pr-16059 branch November 29, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants