Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13321] Pass TempLocation as pipeline option to Dataflow Go for XLang. #16069

Merged
merged 1 commit into from Dec 14, 2021

Conversation

youngoli
Copy link
Contributor

This works because only options in that dataflowOptions struct are visible to Java and Python SDK Harnesses, so any flags needed for cross-language pipelines must be added to that struct.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@youngoli
Copy link
Contributor Author

R: @lostluck @chamikaramj

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #16069 (a8bcfc2) into master (042547c) will decrease coverage by 28.52%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16069       +/-   ##
===========================================
- Coverage   74.61%   46.08%   -28.53%     
===========================================
  Files         640      195      -445     
  Lines       80861    19458    -61403     
===========================================
- Hits        60331     8967    -51364     
+ Misses      19561     9522    -10039     
  Partials      969      969               
Impacted Files Coverage Δ
...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go 16.06% <0.00%> (-0.09%) ⬇️
...dks/python/apache_beam/transforms/external_java.py
...hon/apache_beam/runners/direct/test_stream_impl.py
.../internal/clients/dataflow/dataflow_v1b3_client.py
..._beam/testing/benchmarks/nexmark/queries/query1.py
sdks/python/apache_beam/examples/wordcount.py
...am/testing/benchmarks/nexmark/models/field_name.py
sdks/python/apache_beam/runners/worker/__init__.py
...testing/benchmarks/nexmark/models/nexmark_model.py
sdks/python/apache_beam/transforms/resources.py
... and 436 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042547c...a8bcfc2. Read the comment docs.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we never had that field before. Neat!

…xlang.

This works because only options in that dataflowOptions struct are visible to Java and Python SDK Harnesses, so any flags needed for cross-language pipelines must be added to that struct.
@youngoli
Copy link
Contributor Author

Run Go PostCommit

@aaltay
Copy link
Member

aaltay commented Dec 11, 2021

What is the next step on this PR?

@lostluck
Copy link
Contributor

I usually let @youngoli merge their own PRs.

@youngoli youngoli merged commit 6a552dc into apache:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants