New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9706][py] Supporting ignore_unknown_values for WriteToBigQuery #16081
Conversation
7b0dc12
to
11b9411
Compare
Run Python 3.8 PostCommit |
r: @ihji |
or r: @youngoli |
(@youngoli since you're becoming familiar with BQ IO lately : )) |
11b9411
to
496f975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I have a question just to confirm I'm understanding it correctly.
@@ -697,7 +698,8 @@ def _insert_all_rows( | |||
table_ref_str, | |||
json_rows=rows, | |||
row_ids=insert_ids, | |||
skip_invalid_rows=True, | |||
skip_invalid_rows=skip_invalid_rows, | |||
ignore_unknown_values=ignore_unknown_values, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I'm not missing anything, this is the main change in functionality right? All the other changes are just passing parameters through function signatures until they get here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct!
496f975
to
6e7f893
Compare
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.