Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9706][py] Supporting ignore_unknown_values for WriteToBigQuery #16081

Merged
merged 1 commit into from Nov 30, 2021

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Nov 29, 2021

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member Author

pabloem commented Nov 29, 2021

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented Nov 29, 2021

r: @ihji

@pabloem
Copy link
Member Author

pabloem commented Nov 29, 2021

or r: @youngoli

@pabloem
Copy link
Member Author

pabloem commented Nov 29, 2021

(@youngoli since you're becoming familiar with BQ IO lately : ))

Copy link
Contributor

@youngoli youngoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I have a question just to confirm I'm understanding it correctly.

@@ -697,7 +698,8 @@ def _insert_all_rows(
table_ref_str,
json_rows=rows,
row_ids=insert_ids,
skip_invalid_rows=True,
skip_invalid_rows=skip_invalid_rows,
ignore_unknown_values=ignore_unknown_values,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I'm not missing anything, this is the main change in functionality right? All the other changes are just passing parameters through function signatures until they get here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct!

@pabloem pabloem changed the title [py] Supporting ignore_unknown_values for WriteToBigQuery [BEAM-9706][py] Supporting ignore_unknown_values for WriteToBigQuery Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #16081 (6e7f893) into master (9160ba2) will increase coverage by 37.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16081       +/-   ##
===========================================
+ Coverage   46.08%   83.62%   +37.54%     
===========================================
  Files         195      445      +250     
  Lines       19457    61423    +41966     
===========================================
+ Hits         8967    51367    +42400     
- Misses       9521    10056      +535     
+ Partials      969        0      -969     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py 82.91% <ø> (ø)
sdks/python/apache_beam/io/gcp/bigquery.py 62.81% <100.00%> (ø)
sdks/go/pkg/beam/transforms/stats/count.go
...o/pkg/beam/runners/dataflow/dataflowlib/execute.go
sdks/go/pkg/beam/provision/provision.go
.../go/pkg/beam/runners/dataflow/dataflowlib/fixup.go
sdks/go/pkg/beam/core/runtime/exec/sideinput.go
sdks/go/pkg/beam/core/runtime/graphx/xlang.go
sdks/go/pkg/beam/core/metrics/dumper.go
sdks/go/pkg/beam/core/runtime/exec/hash.go
... and 632 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9160ba2...6e7f893. Read the comment docs.

@pabloem pabloem merged commit 3b9d1d5 into apache:master Nov 30, 2021
@pabloem pabloem deleted the ignore-unknown-values branch November 30, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants