Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13355] add Big Query parameter to enable users to specify load_… #16186

Merged

Conversation

johnjcasey
Copy link
Contributor

@johnjcasey johnjcasey commented Dec 9, 2021

add BigQuery parameter to enable users to specify load_job_project_id

This brings the python BigQuery api in line with the Java api, enabling users to specify a separate project to bill from the table they are loading data into


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@johnjcasey johnjcasey force-pushed the BEAM-13355_add_load_job_project_id branch 2 times, most recently from a2b1400 to 850f723 Compare December 9, 2021 16:33
@johnjcasey johnjcasey force-pushed the BEAM-13355_add_load_job_project_id branch from 850f723 to e7c11b5 Compare December 9, 2021 16:41
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #16186 (749d1a9) into master (5b3f70b) will increase coverage by 37.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16186       +/-   ##
===========================================
+ Coverage   46.08%   83.64%   +37.55%     
===========================================
  Files         195      447      +252     
  Lines       19457    61660    +42203     
===========================================
+ Hits         8967    51576    +42609     
- Misses       9521    10084      +563     
+ Partials      969        0      -969     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 62.85% <100.00%> (ø)
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.73% <100.00%> (ø)
sdks/python/apache_beam/io/gcp/bigquery_tools.py 82.93% <100.00%> (ø)
sdks/go/pkg/beam/core/runtime/xlangx/resolve.go
sdks/go/pkg/beam/core/graph/coder/iterable.go
sdks/go/pkg/beam/core/runtime/exec/reshuffle.go
...o/pkg/beam/runners/dataflow/dataflowlib/metrics.go
sdks/go/pkg/beam/core/runtime/exec/cogbk.go
sdks/go/pkg/beam/util/harnessopts/cache.go
sdks/go/pkg/beam/core/runtime/exec/datasource.go
... and 635 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3f70b...749d1a9. Read the comment docs.

@johnjcasey
Copy link
Contributor Author

R: @chamikaramj

@johnjcasey johnjcasey marked this pull request as ready for review December 9, 2021 17:52
Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnjcasey
Copy link
Contributor Author

retest this please

1 similar comment
@johnjcasey
Copy link
Contributor Author

retest this please

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@chamikaramj chamikaramj merged commit a8162f2 into apache:master Dec 14, 2021
@johnjcasey johnjcasey deleted the BEAM-13355_add_load_job_project_id branch December 14, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants