Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13402] Add another workaround for https://github.com/googleapis/gax-java/issues/1577 and bump Pub/Sub Lite version to pick up another similar workaround #16190

Merged
merged 1 commit into from Dec 10, 2021

Conversation

dpcollins-google
Copy link
Contributor

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…/gax-java/issues/1577 and bump Pub/Sub Lite version to pick up another similar workaround
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #16190 (31a595f) into master (8a7ad0e) will increase coverage by 9.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16190      +/-   ##
==========================================
+ Coverage   74.59%   83.62%   +9.02%     
==========================================
  Files         643      447     -196     
  Lines       81053    61556   -19497     
==========================================
- Hits        60465    51475    -8990     
+ Misses      19618    10081    -9537     
+ Partials      970        0     -970     
Impacted Files Coverage Δ
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (ø)
sdks/go/pkg/beam/transforms/stats/min_switch.go
sdks/go/pkg/beam/io/databaseio/writer.go
sdks/go/pkg/beam/core/runtime/metricsx/urns.go
sdks/go/pkg/beam/core/util/reflectx/call.go
sdks/go/pkg/beam/coder.go
sdks/go/pkg/beam/provision/provision.go
sdks/go/pkg/beam/core/funcx/output.go
sdks/go/pkg/beam/core/runtime/types.go
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7ad0e...31a595f. Read the comment docs.

@dpcollins-google
Copy link
Contributor Author

Run Portable_Python PreCommit

@dpcollins-google
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

1 similar comment
@lostluck
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@lostluck
Copy link
Contributor

Java precommit failure. This one feels relevant:

Execution failed for task ':sdks:java:io:google-cloud-platform:test'.

There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/io/google-cloud-platform/build/reports/tests/test/index.html

No where else we should be changing the pubsub lite version?

@lostluck
Copy link
Contributor

Run Java PreCommit

@lostluck
Copy link
Contributor

Run Java_Examples_Dataflow_Java11 PreCommit

@lostluck
Copy link
Contributor

Run Java_Examples_Dataflow_Java17 PreCommit

@lostluck
Copy link
Contributor

The failures feel unrelated, since the main Java precommit is failing, but I'm not familiar enough with them to be sure. :/

@lostluck
Copy link
Contributor

Ok definitely an unrelated failure, Task :sdks:java:io:kafka:compileTestJava FAILED. Merging.

@lostluck lostluck merged commit ba49cd9 into apache:master Dec 10, 2021
@suztomo
Copy link
Contributor

suztomo commented Dec 10, 2021

Please do not include this commit to 2.35.0 release. (Master branch and subsequent releases are fine.) This would bring unexpected GCP dependencies to 2.35.0 release.

CC: @dzou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants