New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13402] Add another workaround for https://github.com/googleapis/gax-java/issues/1577 and bump Pub/Sub Lite version to pick up another similar workaround #16190
Conversation
…/gax-java/issues/1577 and bump Pub/Sub Lite version to pick up another similar workaround
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## master #16190 +/- ##
==========================================
+ Coverage 74.59% 83.62% +9.02%
==========================================
Files 643 447 -196
Lines 81053 61556 -19497
==========================================
- Hits 60465 51475 -8990
+ Misses 19618 10081 -9537
+ Partials 970 0 -970 Continue to review full report at Codecov.
|
Run Portable_Python PreCommit |
Run Java_Examples_Dataflow PreCommit |
1 similar comment
Run Java_Examples_Dataflow PreCommit |
Java precommit failure. This one feels relevant: Execution failed for task ':sdks:java:io:google-cloud-platform:test'.
No where else we should be changing the pubsub lite version? |
Run Java PreCommit |
Run Java_Examples_Dataflow_Java11 PreCommit |
Run Java_Examples_Dataflow_Java17 PreCommit |
The failures feel unrelated, since the main Java precommit is failing, but I'm not familiar enough with them to be sure. :/ |
Ok definitely an unrelated failure, |
Please do not include this commit to 2.35.0 release. (Master branch and subsequent releases are fine.) This would bring unexpected GCP dependencies to 2.35.0 release. CC: @dzou |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.