[BEAM-13463] [Playground] add retries to check status for run code #16244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,13 +83,14 @@ class GrpcCodeClient implements CodeClient { | |||
| ) { | |||
| return _runSafely(() => createClient(request.sdk) | |||
| .getRunOutput(grpc.GetRunOutputRequest(pipelineUuid: pipelineUuid)) | |||
| .then((response) => _toOutputResponse(response.output))); | |||
| .then((response) => _toOutputResponse(response.output)) | |||
| .catchError((err) => _toOutputResponse(''))); | |||
There was a problem hiding this comment.
There should be a logger in the catchError so that we can find potential problems.
| Future<T> runWithRetry<T>(Future<T> Function() fn, | ||
| {int retryCount = kDefaultRetryCount, | ||
| int retryWaitMs = kDefaultRetryWaitMs, | ||
| int attemptNumber = 1}) async { |
There was a problem hiding this comment.
attemptNumber should not be exposed to the caller. Perhaps move the recursion to a nested helper function or create a class with private functions.
| const kDefaultRetryCount = 5; | ||
| const kDefaultRetryWaitMs = 2000; | ||
|
|
||
| Future<T> runWithRetry<T>(Future<T> Function() fn, |
There was a problem hiding this comment.
Nit: Explain this API by adding a doc comment.
# Conflicts: # playground/frontend/lib/modules/editor/repository/code_repository/code_repository.dart
KonradJanica
approved these changes
Dec 21, 2021
|
LGTM thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added retries for check statuses on run code (https://issues.apache.org/jira/browse/BEAM-13463).
Added 5 retries to check status request with equal interval between them (2 seconds).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.