Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.36.0][BEAM-13575] Sickbay test that is flaky to restore precommit test signal (#16410) #16435

Merged
merged 1 commit into from Jan 5, 2022

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Jan 5, 2022

CP of #16410


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@emilymye
Copy link
Contributor Author

emilymye commented Jan 5, 2022

R: @lukecwik

@emilymye
Copy link
Contributor Author

emilymye commented Jan 5, 2022

Run Java_PVR_Flink_Docker PreCommit

@emilymye
Copy link
Contributor Author

emilymye commented Jan 5, 2022

R: @ibzib

I'm not sure why the Flink PVR precommit is failing now but it was failing on release branch earlier because the Docker task was added post-release-cut.

@ibzib
Copy link
Contributor

ibzib commented Jan 5, 2022

Java_PVR_Flink_Docker is failing with ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? because Jenkins expects it to output Junit tests results, and the no-op task doesn't. It may be best to just ignore Java_PVR_Flink_Docker on the release branch since it's not going to give useful signal either way, and it doesn't seem worthwhile to cherry-pick.

@emilymye
Copy link
Contributor Author

emilymye commented Jan 5, 2022

Do you mean not worthwhile to CP just this empty task or not worthwhile to sickbay the other test as well?

@ibzib
Copy link
Contributor

ibzib commented Jan 5, 2022

Just the empty task. Sickbaying the failing test sgtm.

@emilymye emilymye changed the title Sickbay/fix precommits for release branch [release-2.36.0][BEAM-13575] Sickbay test that is flaky to restore precommit test signal (#16410) Jan 5, 2022
Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilymye emilymye merged commit d5e75c5 into apache:release-2.36.0 Jan 5, 2022
@emilymye emilymye deleted the fixtests-2.36.0 branch January 5, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants