[BEAM-13609] Not all variable length types works properly for Oracle DB

[vitaly-ivanov]

For example RAW(16) fails while comparing field length because the Oracle JDBC driver returns precision = 0 but columnDisplaySize = 16.

Looks like we can take into account columnDisplaySize when precision is zero or negative

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---					---
Java
Python	---					---
XLang						---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[vitaly-ivanov]

R: @timrobertson100 @pabloem

[vitaly-ivanov]

retest this please

[aaltay]

@pabloem - Could you review this or find another reviewer?

[aaltay]

@pabloem - friendly ping? Perhaps @kerrydc could help with finding another reviewer?

[pabloem]

sorry about the delay - and thanks so much for the fix @vitaly-ivanov !

I don't see a lot of information regarding this issue, which is interesting. I think your current fix may work for RAW, but may not work for e.g. COUNT(*), which would return a BigInt (and what does that return as the columnDisplaySize?)

I see this: https://stackoverflow.com/questions/1410267/oracle-resultsetmetadata-getprecision-getscale

[pabloem]

I suppose that your fix improves the functionality, even if it doesn't address all possible cases. I wonder if we could also throw a more informative error message that would directusers to use CAST

[pabloem]

@vitaly-ivanov what are your thoughts on the above comments? Do you think there could be a way of handling also the COUNT(*) case?

[github-actions]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

[github-actions]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.