Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13218] Re-enable PubSubIntegrationTest.test_streaming_with_attributes #16497

Merged
merged 1 commit into from Feb 23, 2022

Conversation

yeandy
Copy link
Contributor

@yeandy yeandy commented Jan 12, 2022

PubSubIntegrationTest. test_streaming_with_attributes has been flaky, and was previously sickbayed in #16251. We've identified the issue to be related to Dataflow service, so are now reenabling this test.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@yeandy
Copy link
Contributor Author

yeandy commented Jan 12, 2022

Run Python 3.6 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jan 12, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Jan 12, 2022

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #16497 (3e1096f) into master (9794fb4) will increase coverage by 9.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16497      +/-   ##
==========================================
+ Coverage   74.60%   83.64%   +9.03%     
==========================================
  Files         654      452     -202     
  Lines       82029    62168   -19861     
==========================================
- Hits        61201    52000    -9201     
+ Misses      19841    10168    -9673     
+ Partials      987        0     -987     
Impacted Files Coverage Δ
...pache_beam/dataframe/pandas_top_level_functions.py 90.52% <0.00%> (-3.16%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.14% <0.00%> (-0.50%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.90% <0.00%> (-0.16%) ⬇️
sdks/go/pkg/beam/util/harnessopts/cache.go
sdks/go/pkg/beam/io/bigqueryio/bigquery.go
sdks/go/pkg/beam/artifact/stage.go
sdks/go/pkg/beam/core/runtime/coderx/string.go
sdks/go/pkg/beam/core/runtime/graphx/user.go
sdks/go/pkg/beam/core/runtime/exec/pcollection.go
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9794fb4...3e1096f. Read the comment docs.

@yeandy
Copy link
Contributor Author

yeandy commented Jan 13, 2022

R: @TheNeuralBit
Looks like even with the increased timeout, test_streaming_with_attributes is having the original timestamp attributes error that you originally reported. Looking into it now.

@TheNeuralBit
Copy link
Member

Should we revert this PR?

@yeandy
Copy link
Contributor Author

yeandy commented Jan 19, 2022

Let's keep it up for now so we can test timeouts when we resolve the timestamp issue.

@TheNeuralBit
Copy link
Member

Sounds good!

@aaltay
Copy link
Member

aaltay commented Feb 5, 2022

Do we still need this PR?

@yeandy
Copy link
Contributor Author

yeandy commented Feb 7, 2022

I think we can repurpose it to unskip the test_streaming_with_attributes test.

@yeandy
Copy link
Contributor Author

yeandy commented Feb 7, 2022

Run Python 3.8 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 7, 2022

Run Python 3.7 PostCommit

2 similar comments
@yeandy
Copy link
Contributor Author

yeandy commented Feb 9, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 9, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 9, 2022

Run PythonDocs PreCommit

@yeandy yeandy changed the title [BEAM-13218] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_with_attributes [BEAM-13218] Re-enable PubSubIntegrationTest.test_streaming_with_attributes Feb 9, 2022
@yeandy
Copy link
Contributor Author

yeandy commented Feb 14, 2022

Run Python 3.7 PostCommit

6 similar comments
@yeandy
Copy link
Contributor Author

yeandy commented Feb 14, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 14, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 14, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 22, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 22, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 22, 2022

Run Python 3.7 PostCommit

@yeandy
Copy link
Contributor Author

yeandy commented Feb 23, 2022

Run Python 3.8 PostCommit

@TheNeuralBit
Copy link
Member

Run Python 3.7 PostCommit

@TheNeuralBit
Copy link
Member

Run Python 3.8 PostCommit

@TheNeuralBit
Copy link
Member

Passed in Python 3.8 PostCommit! 🎉
image

Python 3.7 PostCommit failure looks unrelated

@TheNeuralBit TheNeuralBit merged commit 42de462 into apache:master Feb 23, 2022
@yeandy
Copy link
Contributor Author

yeandy commented Feb 24, 2022

Finally! Thanks for the retest and merge @TheNeuralBit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants