New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13218] Re-enable PubSubIntegrationTest.test_streaming_with_attributes #16497
[BEAM-13218] Re-enable PubSubIntegrationTest.test_streaming_with_attributes #16497
Conversation
Run Python 3.6 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.8 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #16497 +/- ##
==========================================
+ Coverage 74.60% 83.64% +9.03%
==========================================
Files 654 452 -202
Lines 82029 62168 -19861
==========================================
- Hits 61201 52000 -9201
+ Misses 19841 10168 -9673
+ Partials 987 0 -987
Continue to review full report at Codecov.
|
R: @TheNeuralBit |
Should we revert this PR? |
Let's keep it up for now so we can test timeouts when we resolve the |
Sounds good! |
Do we still need this PR? |
ee1c642
to
3e1096f
Compare
I think we can repurpose it to unskip the |
Run Python 3.8 PostCommit |
Run Python 3.7 PostCommit |
2 similar comments
Run Python 3.7 PostCommit |
Run Python 3.7 PostCommit |
Run PythonDocs PreCommit |
Run Python 3.7 PostCommit |
6 similar comments
Run Python 3.7 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.8 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.8 PostCommit |
Finally! Thanks for the retest and merge @TheNeuralBit! |
PubSubIntegrationTest. test_streaming_with_attributes
has been flaky, and was previously sickbayed in #16251. We've identified the issue to be related to Dataflow service, so are now reenabling this test.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.