Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example #16519

Merged
merged 3 commits into from
Jan 19, 2022
Merged

[BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example #16519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7ca713
[BEAM-13639] Added log about cached results for precompiled examples
miamihotline Jan 13, 2022
f1522d7
Merge remote-tracking branch 'origin/master' into BEAM-13639
miamihotline Jan 17, 2022
9d35582
[BEAM-13639] Fixed _getPipelineResult method of code_repository
miamihotline Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions playground/frontend/lib/modules/editor/repository/code_repository/code_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ class CodeRepository {
final log = responses[1];
final error = responses[2];
return RunCodeResult(
pipelineUuid: pipelineUuid,
status: status,
output: prevOutput + output.output + error.output,
log: prevLog + log.output,
Expand Down
5 changes: 4 additions & 1 deletion playground/frontend/lib/pages/playground/states/playground_state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ const kTitle = 'Catalog';
const kExecutionCancelledText = '\nPipeline cancelled';
const kPipelineOptionsParseError =
'Failed to parse pipeline options, please check the format (example: --key1 value1 --key2 value2), only alphanumeric and ",*,/,-,:,;,\',. symbols are allowed';
const kCachedResultsLog =
'The results of this example are taken from the Apache Beam Playground cache.\n';

class PlaygroundState with ChangeNotifier {
late SDK _sdk;
Expand Down Expand Up @@ -180,10 +182,11 @@ class PlaygroundState with ChangeNotifier {
notifyListeners();
// add a little delay to improve user experience
await Future.delayed(kPrecompiledDelay);
String logs = _selectedExample!.logs ?? '';
_result = RunCodeResult(
status: RunCodeStatus.finished,
output: _selectedExample!.outputs,
log: _selectedExample!.logs,
log: kCachedResultsLog + logs,
);
_executionTime?.close();
notifyListeners();
Expand Down