Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9195] Bump org.testcontainers to 1.16.3 #16661

Merged

Conversation

masahitojp
Copy link
Contributor

@masahitojp masahitojp commented Jan 31, 2022

[BEAM-9195] Bump org.testcontainers to 1.16.3


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #16661 (23dc9ce) into master (419c03c) will increase coverage by 36.70%.
The diff coverage is n/a.

❗ Current head 23dc9ce differs from pull request most recent head ed693e5. Consider uploading reports for the commit ed693e5 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16661       +/-   ##
===========================================
+ Coverage   46.88%   83.59%   +36.70%     
===========================================
  Files         203      452      +249     
  Lines       20073    62274    +42201     
===========================================
+ Hits         9412    52057    +42645     
- Misses       9661    10217      +556     
+ Partials     1000        0     -1000     
Impacted Files Coverage Δ
sdks/go/pkg/beam/core/util/reflectx/structs.go
sdks/go/pkg/beam/core/graph/coder/time.go
sdks/go/pkg/beam/core/funcx/sideinput.go
sdks/go/pkg/beam/core/runtime/harness/sampler.go
sdks/go/pkg/beam/core/runtime/exec/status.go
sdks/go/pkg/beam/transforms/stats/stats.shims.go
sdks/go/pkg/beam/core/runtime/exec/datasink.go
sdks/go/pkg/beam/core/util/reflectx/types.go
sdks/go/pkg/beam/artifact/materialize.go
sdks/go/pkg/beam/core/runtime/harness/logging.go
... and 645 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419c03c...ed693e5. Read the comment docs.

@masahitojp masahitojp changed the title [BEAM-9195] Bump org.testcontainers to 1.16.3 [WIP][BEAM-9195] Bump org.testcontainers to 1.16.3 Feb 7, 2022
@masahitojp masahitojp force-pushed the beam-9195-bump-org.textcontainers-1.16.x branch from 54d41c0 to 23dc9ce Compare February 11, 2022 04:59
@masahitojp
Copy link
Contributor Author

Run Python PreCommit

@masahitojp masahitojp force-pushed the beam-9195-bump-org.textcontainers-1.16.x branch from 23dc9ce to ed693e5 Compare February 12, 2022 09:04
@masahitojp masahitojp changed the title [WIP][BEAM-9195] Bump org.testcontainers to 1.16.3 [BEAM-9195] Bump org.testcontainers to 1.16.3 Feb 12, 2022
@masahitojp
Copy link
Contributor Author

R: @iemejia or @aromanenko-dev

I've checked this pr :-)
if you know better reviewer, please share me!

@iemejia iemejia self-requested a review February 12, 2022 15:46
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@iemejia iemejia merged commit c73066c into apache:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants