-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13799] Create an Interactive Beam Dataproc package for users to manage clusters with #16691
Conversation
R: @KevinGG |
Codecov Report
@@ Coverage Diff @@
## master #16691 +/- ##
========================================
Coverage 83.65% 83.65%
========================================
Files 452 452
Lines 62424 62161 -263
========================================
- Hits 52222 52002 -220
+ Misses 10202 10159 -43
Continue to review full report at Codecov.
|
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a few nits.
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Show resolved
Hide resolved
bb80086
to
9ae8784
Compare
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
d6ddf36
to
30adedd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
41e505a
to
fc6bb5f
Compare
… manage clusters with
fc6bb5f
to
1c95bd9
Compare
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.