[BEAM-13786] [Playground] [Bugfix] Update CI/CD to verify only single-file examples #16701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaninArtur
suggested changes
Feb 2, 2022
playground/infrastructure/ci_cd.py
Outdated
Comment on lines
87
to
88
| single_file_examples = [example for example in examples | ||
| if example.tag.multifile is False] |
There was a problem hiding this comment.
Let's move this part to the ci_helper.verify_examples function.
ilya-kozyrev
suggested changes
Feb 2, 2022
Comment on lines
50
to
52
| single_file_examples = [ | ||
| example for example in examples if example.tag.multifile is False | ||
| ] |
There was a problem hiding this comment.
what about use filter function ro filtering?
Suggested change
| single_file_examples = [ | |
| example for example in examples if example.tag.multifile is False | |
| ] | |
| single_file_examples = filter(lambda example: example.multifile, examples) |
Just remember, that filter returns a filter object, that can be iterated, but is not available for slices
Comment on lines
47
to
48
| single_file_examples = [example for example in examples | ||
| if example.tag.multifile is False] |
There was a problem hiding this comment.
same, can we use the filter for filtering? :)
ilya-kozyrev
approved these changes
Feb 4, 2022
| logging.info("Start of executing Playground examples ...") | ||
| asyncio.run(self._get_outputs(examples)) | ||
| logging.info("Finish of executing Playground examples") | ||
| single_file_examples = list(filter( |
There was a problem hiding this comment.
you don't need cast from filter results to list if you plan to iterate through.
There was a problem hiding this comment.
I see it required to be cast to list :) LGTM then
|
R: @pabloem |
|
lgtm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-13786]
Update CI/CD to verify only single-file examples
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.