-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13793] Adding external transform registry for schema-based payl… #16800
Conversation
5d7a815
to
676b49a
Compare
Codecov Report
@@ Coverage Diff @@
## master #16800 +/- ##
==========================================
- Coverage 73.82% 73.82% -0.01%
==========================================
Files 667 668 +1
Lines 87392 87350 -42
==========================================
- Hits 64521 64489 -32
+ Misses 21768 21758 -10
Partials 1103 1103
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
274dd61
to
418da83
Compare
I haven't looked at the code itself, but as mentioned on the doc, I'm not sure how much value we can get from a transform registry if the transforms in question need to be explicitly imported in order to be registered. |
…oad to Python expansion service
What is the next step for this PR? |
I think we can drop this PR now, right? |
Yes, we don't need this. |
…oad to Python expansion service
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.