Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13793] Adding external transform registry for schema-based payl… #16800

Closed
wants to merge 1 commit into from

Conversation

ihji
Copy link
Contributor

@ihji ihji commented Feb 9, 2022

…oad to Python expansion service

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ihji ihji changed the title [BEAM-13793] Adding external transform registry for schema-based payl… [WIP/BEAM-13793] Adding external transform registry for schema-based payl… Feb 9, 2022
@github-actions github-actions bot added the python label Feb 9, 2022
@ihji ihji force-pushed the BEAM-13793 branch 4 times, most recently from 5d7a815 to 676b49a Compare February 10, 2022 20:25
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #16800 (c887d46) into master (9833b7b) will decrease coverage by 0.00%.
The diff coverage is 88.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16800      +/-   ##
==========================================
- Coverage   73.82%   73.82%   -0.01%     
==========================================
  Files         667      668       +1     
  Lines       87392    87350      -42     
==========================================
- Hits        64521    64489      -32     
+ Misses      21768    21758      -10     
  Partials     1103     1103              
Flag Coverage Δ
python 83.65% <88.37%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...runners/portability/external_transform_registry.py 87.80% <87.80%> (ø)
sdks/python/apache_beam/portability/common_urns.py 100.00% <100.00%> (ø)
...ache_beam/runners/portability/expansion_service.py 93.18% <100.00%> (ø)
sdks/python/apache_beam/io/localfilesystem.py 91.47% <0.00%> (-0.78%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 80.62% <0.00%> (-0.78%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.85% <0.00%> (-0.51%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 94.85% <0.00%> (-0.43%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️
...he_beam/portability/api/external_transforms_pb2.py 100.00% <0.00%> (ø)
...am/portability/api/external_transforms_pb2_urns.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9833b7b...c887d46. Read the comment docs.

@ihji ihji changed the title [WIP/BEAM-13793] Adding external transform registry for schema-based payl… [BEAM-13793] Adding external transform registry for schema-based payl… Feb 10, 2022
@ihji ihji force-pushed the BEAM-13793 branch 2 times, most recently from 274dd61 to 418da83 Compare February 11, 2022 08:18
@ihji
Copy link
Contributor Author

ihji commented Feb 11, 2022

R: @robertwb @chamikaramj

@robertwb
Copy link
Contributor

I haven't looked at the code itself, but as mentioned on the doc, I'm not sure how much value we can get from a transform registry if the transforms in question need to be explicitly imported in order to be registered.

@aaltay
Copy link
Member

aaltay commented Mar 18, 2022

What is the next step for this PR?

@robertwb
Copy link
Contributor

I think we can drop this PR now, right?

@ihji
Copy link
Contributor Author

ihji commented Apr 1, 2022

Yes, we don't need this.

@ihji ihji closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants