Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13836] Fix the answers placeholders locations in the Python katas #16820

Merged
merged 1 commit into from Feb 14, 2022

Conversation

iht
Copy link
Contributor

@iht iht commented Feb 11, 2022

The Python katas placeholder locations were wrong after some tags were added to the code (see #16192).

This pull request puts the placeholders back in the right locations for the katas to work with the Edu plugin of PyCharm/IntelliJ.

It also adds the following changes:

  • Uodate to Beam 2.36 and the lates version of pytz (required dependency for some tests)
  • Add tags to some untagged katas ( the three katas in the Triggers section)
  • Groom the test and code of the Triggers katas (to match the same style used in the rest of the katas)

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@iht
Copy link
Contributor Author

iht commented Feb 11, 2022

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Feb 11, 2022

thanks so much @iht LGTM

@aaltay
Copy link
Member

aaltay commented Feb 12, 2022

Out of curiosity how do you calculate, verify these offset numbers? Is there a way to keep them automatically updated?

@iht
Copy link
Contributor Author

iht commented Feb 12, 2022

If you use the Edu plugin, you have an option in the contextual menu to add an answer placeholder. There is more info here: https://plugins.jetbrains.com/plugin/10081-edutools/docs/framework-lessons-guide-for-educators.html#framework_lesson_placeholders

So what I did is removing the previous placeholders, then I created new ones with the same contents, but different locations.

For the katas to be edited "correctly", you have to use the Edu plugin to edit the code, using the "course" mode, and the answer placeholders are automatically updated too (https://plugins.jetbrains.com/plugin/10081-edutools/docs/educator-start-guide.html#create_tasks).

There is a minor caveat: IntelliJ removes the license header from the YAML files, so you have to re-add those again after you finish editing the code.

@pabloem pabloem merged commit 0148d30 into apache:master Feb 14, 2022
@iht iht deleted the groom_katas branch April 20, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants