[BEAM-13870] [Playground] Increase test coverage for the cache package #16826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaninArtur
reviewed
Feb 14, 2022
KhaninArtur
suggested changes
Feb 14, 2022
Comment on lines
109
to
110
| // Test case with calling GetValue method with exist value the expiration time of which has ended. | ||
| // As a result, want to receive an error. |
There was a problem hiding this comment.
Thank you for adding these comments, could you please also add comments for other tests in these files? So every test in local_cache_test.go and redis_cache_test.go has a corresponding comment😊
daria-malkova
suggested changes
Feb 15, 2022
| { | ||
| // Test case with calling startGC method with nil items. | ||
| // As a result, items stay the same. | ||
| name: "Checking for deleting expired pipelines with nil items", |
| want *Cache | ||
| }{ | ||
| { | ||
| // Test case with calling New method. |
| @@ -243,6 +243,23 @@ func TestRedisCache_SetValue(t *testing.T) { | |||
| }, | |||
| wantErr: false, | |||
| }, | |||
| { | |||
| // Test case with calling SetValue method with incorrect value. | |||
| @@ -535,6 +555,28 @@ func Test_unmarshalBySubKey(t *testing.T) { | |||
| want: output, | |||
| wantErr: false, | |||
| }, | |||
| { | |||
| // Test case with calling unmarshalBySubKey method with Canceled subKey. | |||
| // As a result, want to receive false. | |||
There was a problem hiding this comment.
Why it will be false?
There was a problem hiding this comment.
@daria-malkova because canceledValue is JSON encoding of the false.
| }{ | ||
| { | ||
| // Test case with calling SetExpTime method with pipelineId and his expiration time. |
daria-malkova
suggested changes
Feb 18, 2022
| @@ -103,6 +105,23 @@ func TestLocalCache_GetValue(t *testing.T) { | |||
| want: nil, | |||
| wantErr: true, | |||
| }, | |||
| { | |||
| // Test case with calling GetValue method with existing value that is expiring. | |||
| @@ -159,6 +178,23 @@ func TestLocalCache_SetValue(t *testing.T) { | |||
| }, | |||
| wantErr: false, | |||
| }, | |||
| { | |||
| // Test case with calling SetValue method with RunOutputIndex subKey. | |||
| wantErr: false, | ||
| }, | ||
| { | ||
| // Test case with calling SetExpTime method with pipelineId which not set in cache and expiration time. |
| @@ -68,7 +68,7 @@ func TestRedisCache_GetValue(t *testing.T) { | |||
| wantErr: true, | |||
| }, | |||
| { | |||
| name: "all success", | |||
| name: "get existing value", | |||
There was a problem hiding this comment.
Sometimes you have a name with an upper case letter, but sometimes with lower case. Do the same everywhere
There was a problem hiding this comment.
I agree, let's start all test names with upper case letters.
E.g. here
Suggested change
| name: "get existing value", | |
| name: "Get existing value", |
KhaninArtur
suggested changes
Feb 18, 2022
| @@ -68,7 +68,7 @@ func TestRedisCache_GetValue(t *testing.T) { | |||
| wantErr: true, | |||
| }, | |||
| { | |||
| name: "all success", | |||
| name: "get existing value", | |||
There was a problem hiding this comment.
I agree, let's start all test names with upper case letters.
E.g. here
Suggested change
| name: "get existing value", | |
| name: "Get existing value", |
|
R: @pabloem |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-13870]
Add unit tests to increase test coverage for the cache package
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.