Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JdbcIO autosharding in Python #16921

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Feb 22, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@chamikaramj
Copy link
Contributor

(let's add a Jira or point to an existing Jira for tracking)

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #16921 (5025f4e) into master (5345834) will increase coverage by 9.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16921      +/-   ##
==========================================
+ Coverage   74.67%   83.80%   +9.13%     
==========================================
  Files         657      468     -189     
  Lines       82593    65268   -17325     
==========================================
- Hits        61674    54697    -6977     
+ Misses      19919    10571    -9348     
+ Partials     1000        0    -1000     
Flag Coverage Δ
python 83.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/jdbc.py 78.26% <ø> (ø)
...s/interactive/dataproc/dataproc_cluster_manager.py 77.41% <0.00%> (-4.01%) ⬇️
...ache_beam/runners/dataflow/test_dataflow_runner.py 29.62% <0.00%> (-3.03%) ⬇️
...nternal/clients/cloudbuild/cloudbuild_v1_client.py 52.21% <0.00%> (-2.97%) ⬇️
sdks/python/apache_beam/internal/gcp/auth.py 78.66% <0.00%> (-2.82%) ⬇️
...ers/portability/fn_api_runner/watermark_manager.py 93.33% <0.00%> (-2.67%) ⬇️
sdks/python/apache_beam/coders/row_coder.py 94.49% <0.00%> (-2.51%) ⬇️
sdks/python/apache_beam/utils/retry.py 83.05% <0.00%> (-2.39%) ⬇️
sdks/python/apache_beam/runners/common.py 87.94% <0.00%> (-2.04%) ⬇️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 88.65% <0.00%> (-1.35%) ⬇️
... and 379 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5345834...5025f4e. Read the comment docs.

@pabloem
Copy link
Member Author

pabloem commented Mar 17, 2022

Run Python 3.8 PostCommit

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 16, 2022
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 24, 2022
@pabloem pabloem reopened this May 31, 2022
@pabloem
Copy link
Member Author

pabloem commented May 31, 2022

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented May 31, 2022

Run PythonFormatter PreCommit

@pabloem
Copy link
Member Author

pabloem commented May 31, 2022

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented May 31, 2022

Run PythonDocs PreCommit

@pabloem
Copy link
Member Author

pabloem commented May 31, 2022

Run Python PreCommit

@github-actions github-actions bot removed the stale label Jun 1, 2022
@pabloem
Copy link
Member Author

pabloem commented Jun 1, 2022

Run Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 1, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 1, 2022

Run Java_Examples_Dataflow PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 1, 2022

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 1, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 1, 2022

Run Python PreCommit

@pabloem pabloem merged commit f24cedf into apache:master Jun 1, 2022
@pabloem pabloem deleted the py-jdbc-autosharding branch June 1, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants