Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-14005] Fix ignored exception in BatchSpannerRead #16960

Merged
merged 1 commit into from Feb 28, 2022
Merged

[BEAM-14005] Fix ignored exception in BatchSpannerRead #16960

merged 1 commit into from Feb 28, 2022
+114 −16

Conversation

nielm
Copy link
Contributor

@nielm nielm commented Feb 26, 2022

Failures to read from Spanner were ignored, and the "ok" serviceCallMetric was updated before the read took place.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@nielm
Copy link
Contributor Author

nielm commented Feb 26, 2022 •
edited

@chamikaramj @KevinGG for review
@TheNeuralBit for potential cherry-pick

@nielm
Copy link
Contributor Author

nielm commented Feb 26, 2022

Run Java PreCommit

chamikaramj
chamikaramj reviewed Feb 26, 2022
View reviewed changes
Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

...oogle-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java Show resolved Hide resolved
@nielm
Fix ignored exception in BatchSpannerRead.
67eb27f 
Failures to read from Spanner were ignored, and the "ok" serviceCallMwtric was updated before the read took place.

Fix code and tests.
@nielm
Copy link
Contributor Author

nielm commented Feb 26, 2022

Run Java PreCommit

chamikaramj
chamikaramj approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@chamikaramj
Copy link
Contributor

Run Java PreCommit

@chamikaramj
Copy link
Contributor

Checkstyle failure is unrelated: #16962

@nielm
Copy link
Contributor Author

nielm commented Feb 28, 2022

Run Java PreCommit

@TheNeuralBit
Copy link
Member

PreCommit failed with:

13:45:10 1: Task failed with an exception.
13:45:10 -----------
13:45:10 * What went wrong:
13:45:10 Execution failed for task ':sdks:java:fn-execution:analyzeClassesDependencies'.
13:45:10 > Dependency analysis found issues.
13:45:10   usedUndeclaredArtifacts
13:45:10    - org.apache.avro:avro:1.8.2@jar

But this seems to be happening at head

@TheNeuralBit
Copy link
Member

Looks like the precommit failure will be fixed by #16966

@lukecwik
Copy link
Member

Run Java PreCommit

@TheNeuralBit TheNeuralBit mentioned this pull request Feb 28, 2022
Merged
@lukecwik
Copy link
Member

Run Java PreCommit

@KevinGG KevinGG merged commit d9d3c93 into apache:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinGG KevinGG KevinGG approved these changes

@chamikaramj chamikaramj chamikaramj approved these changes

Assignees
No one assigned
Labels
gcp io java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nielm @chamikaramj @TheNeuralBit @lukecwik @KevinGG