[BEAM-13893] improved coverage of jobopts package

[riteshghorse]

Improved coverage of jobopts package. Part of effort to improve code coverage of Go SDK.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[riteshghorse]

R: @jrmccluskey @damccorm

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[codecov]

Codecov Report

Merging #17003 (69b7070) into master (06e7c20) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #17003      +/-   ##
==========================================
+ Coverage   73.83%   73.88%   +0.05%     
==========================================
  Files         664      669       +5     
  Lines       87272    87502     +230     
==========================================
+ Hits        64434    64648     +214     
- Misses      21735    21743       +8     
- Partials     1103     1111       +8     

Flag	Coverage Δ
go	49.40% <100.00%> (+0.40%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdks/go/pkg/beam/options/jobopts/options.go	87.27% <100.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/plan.go	48.61% <0.00%> (-8.80%)	⬇️
sdks/go/pkg/beam/core/runtime/harness/harness.go	11.26% <0.00%> (-1.43%)	⬇️
sdks/go/pkg/beam/runners/direct/buffer.go	77.46% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/pardo.go	50.45% <0.00%> (ø)
sdks/go/pkg/beam/core/graph/window/windows.go	82.60% <0.00%> (ø)
sdks/go/pkg/beam/core/graph/window/fn.go	53.84% <0.00%> (ø)
sdks/go/pkg/beam/core/graph/window/strategy.go	0.00% <0.00%> (ø)
sdks/go/pkg/beam/options/jobopts/stringSlice.go	71.42% <0.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e7c20...69b7070. Read the comment docs.

[damccorm]

This LGTM - not too much going on in this package

[damccorm]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

I'm considering getting rid of that message - thoughts on the current experience? I could always add a label (something like pr-bot-disabled) instead. The advantage of keeping it is that it nudges people towards using the new experience.

[jrmccluskey]

LGTM, just left a nit

[riteshghorse]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

I'm considering getting rid of that message - thoughts on the current experience? I could always add a label (something like pr-bot-disabled) instead. The advantage of keeping it is that it nudges people towards using the new experience.

I don't mind getting that message. It makes folks aware that such bot exists (I wanted to try the bot but the habit of tagging reviewers kicked in earlier:P).

[riteshghorse]

R: @youngoli

[youngoli]

Looks good to me.