Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14076] [SnowflakeIO] Add support for GEOGRAPHY column #17056

Merged

Conversation

sfc-gh-kbregula
Copy link
Contributor

@sfc-gh-kbregula sfc-gh-kbregula commented Mar 9, 2022

To be able to create GEOGRAPHY columns when CreateDisposition == CREATE_IF_NEEDED, I created a new SnowflakeGeography class and registered it in SnowflakeDataType class.

R: @pabloem
Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #17056 (32771dc) into master (2a23166) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17056   +/-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files         667      667           
  Lines       88071    88071           
=======================================
  Hits        65032    65032           
  Misses      21932    21932           
  Partials     1107     1107           
Flag Coverage Δ
python 83.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/snowflake.py 62.74% <ø> (ø)
...che_beam/runners/interactive/interactive_runner.py 92.02% <0.00%> (-0.73%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.64% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a23166...32771dc. Read the comment docs.

@pabloem
Copy link
Member

pabloem commented Mar 9, 2022

fyi @sfc-gh-kbregula there seem to be issues with Python docs

@sfc-gh-kbregula
Copy link
Contributor Author

@pabloem fixed.

@sfc-gh-kbregula
Copy link
Contributor Author

I'm not sure, but the tests look flaky.

@pabloem
Copy link
Member

pabloem commented Mar 11, 2022

lgtm thanks!

@pabloem pabloem merged commit 9e0aa6b into apache:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants