Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14091] Fixing Interactive Beam show/collect for remote runners #17072

Merged

Conversation

victorplusc
Copy link
Contributor

@victorplusc victorplusc commented Mar 11, 2022

  • Bug: the show and collect commands under Interactive Beam would eventually call a PipelineFragment to execute the InteractiveRunner corresponding to the given PCollection. The PipelineFragment by default does not wait for pipeline to finish execution, and when a pipeline runs the FlinkRunner remotely, the Interactive Environment is not updated with the results of the pipeline run. Subsequent calls to ib.show/ib.collect would rerun the pipeline instead of directly retrieving the results from the Interactive Environment.
  • Setting the blocking to be True when using the FlinkRunner inside the RecordingManager.record() method when calling the .run() method of the PipelineFragment properly saves completed pipeline results in the Interactive Environment and prevents a need to rerun the pipelines again on subsequent calls to ib.show/ib.collect.
  • ASF Jira thread: https://issues.apache.org/jira/browse/BEAM-14091

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@victorplusc
Copy link
Contributor Author

R: @KevinGG
R: @rohdesamuel

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #17072 (825d604) into master (15e636f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17072   +/-   ##
=======================================
  Coverage   73.95%   73.95%           
=======================================
  Files         669      669           
  Lines       88156    88159    +3     
=======================================
+ Hits        65193    65197    +4     
+ Misses      21851    21850    -1     
  Partials     1112     1112           
Flag Coverage Δ
python 83.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eam/runners/interactive/interactive_environment.py 90.51% <100.00%> (-0.23%) ⬇️
...ache_beam/runners/interactive/recording_manager.py 96.58% <100.00%> (+0.03%) ⬆️
...ks/python/apache_beam/runners/interactive/utils.py 95.41% <100.00%> (+0.17%) ⬆️
sdks/python/apache_beam/transforms/util.py 95.96% <0.00%> (-0.17%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.64% <0.00%> (+0.12%) ⬆️
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py 75.51% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e636f...825d604. Read the comment docs.

Copy link
Contributor

@KevinGG KevinGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit

@victorplusc
Copy link
Contributor Author

Run Python PreCommit

@victorplusc victorplusc force-pushed the interactive_beam_fix_for_remote_execution branch from d3352bd to e6c078b Compare March 16, 2022 18:24
Copy link
Contributor

@KevinGG KevinGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorplusc
Copy link
Contributor Author

Run Python PreCommit

@KevinGG KevinGG merged commit 9c17960 into apache:master Mar 16, 2022
@victorplusc victorplusc deleted the interactive_beam_fix_for_remote_execution branch March 16, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants