-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14091] Fixing Interactive Beam show/collect for remote runners #17072
[BEAM-14091] Fixing Interactive Beam show/collect for remote runners #17072
Conversation
R: @KevinGG |
Codecov Report
@@ Coverage Diff @@
## master #17072 +/- ##
=======================================
Coverage 73.95% 73.95%
=======================================
Files 669 669
Lines 88156 88159 +3
=======================================
+ Hits 65193 65197 +4
+ Misses 21851 21850 -1
Partials 1112 1112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit
sdks/python/apache_beam/runners/interactive/recording_manager.py
Outdated
Show resolved
Hide resolved
Run Python PreCommit |
d3352bd
to
e6c078b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run Python PreCommit |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.