-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14098] wrapper for postgres on JDBC IO GO SDK #17088
Conversation
Run Go PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #17088 +/- ##
==========================================
+ Coverage 73.95% 73.96% +0.01%
==========================================
Files 667 671 +4
Lines 88072 88182 +110
==========================================
+ Hits 65135 65226 +91
- Misses 21826 21844 +18
- Partials 1111 1112 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label go. Available commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There were a few typos that I'm going to apply to the branch, but otherwise I'll merge this in. Thanks!
Create wrappers for Postgres on JDBC IO to abstract driver details and hence provide a cleaner user experience.
More details on BEAM-14098
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.