Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14098] wrapper for postgres on JDBC IO GO SDK #17088

Merged
merged 4 commits into from
Mar 19, 2022

Conversation

riteshghorse
Copy link
Contributor

Create wrappers for Postgres on JDBC IO to abstract driver details and hence provide a cleaner user experience.
More details on BEAM-14098


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@riteshghorse
Copy link
Contributor Author

Run Go PostCommit

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #17088 (95b35f6) into master (2cec50b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17088      +/-   ##
==========================================
+ Coverage   73.95%   73.96%   +0.01%     
==========================================
  Files         667      671       +4     
  Lines       88072    88182     +110     
==========================================
+ Hits        65135    65226      +91     
- Misses      21826    21844      +18     
- Partials     1111     1112       +1     
Flag Coverage Δ
go 49.45% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/util/reflectx/tags.go 0.00% <0.00%> (ø)
sdks/go/pkg/beam/core/util/ioutilx/read.go 74.35% <0.00%> (ø)
sdks/go/pkg/beam/core/util/ioutilx/write.go 100.00% <0.00%> (ø)
sdks/go/pkg/beam/options/jobopts/stringSlice.go 71.42% <0.00%> (ø)
sdks/go/pkg/beam/options/jobopts/options.go 87.27% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/pipelinex/replace.go 66.66% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cec50b...95b35f6. Read the comment docs.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@riteshghorse
Copy link
Contributor Author

R: @youngoli @lostluck

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There were a few typos that I'm going to apply to the branch, but otherwise I'll merge this in. Thanks!

sdks/go/pkg/beam/io/xlang/jdbcio/jdbc.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/io/xlang/jdbcio/jdbc.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/io/xlang/jdbcio/jdbc.go Outdated Show resolved Hide resolved
@lostluck lostluck merged commit 5494ec8 into apache:master Mar 19, 2022
@riteshghorse riteshghorse deleted the beam14098 branch June 27, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants