Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14141] Set Interactive Beam to use the default Dataproc image #17146

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

victorplusc
Copy link
Contributor

@victorplusc victorplusc commented Mar 21, 2022

  • Resolution to dependency issue discussed in: BEAM-10430.
    • The Dataproc team should handle this issue and fix it in a newer version.
  • To account for the image fix being in the future, we can default the image version, which will eventually be set to a version of the image with the fix after it has been implemented. By not specifying an image version during cluster creation, the default image version is used.
  • ASF Jira: https://issues.apache.org/jira/browse/BEAM-14141

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@victorplusc
Copy link
Contributor Author

R: @KevinGG
R: @rohdesamuel

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #17146 (4dcf018) into master (d352d60) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17146      +/-   ##
==========================================
- Coverage   73.95%   73.95%   -0.01%     
==========================================
  Files         671      671              
  Lines       88227    88230       +3     
==========================================
+ Hits        65252    65254       +2     
- Misses      21863    21864       +1     
  Partials     1112     1112              
Flag Coverage Δ
python 83.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/interactive/dataproc/dataproc_cluster_manager.py 88.32% <ø> (-0.26%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 81.39% <ø> (ø)
...n/apache_beam/runners/interactive/cache_manager.py 87.58% <0.00%> (-1.01%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.90% <0.00%> (-0.16%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.51% <0.00%> (ø)
...che_beam/runners/interactive/interactive_runner.py 92.85% <0.00%> (+0.82%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 79.71% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d352d60...4dcf018. Read the comment docs.

Copy link
Contributor

@KevinGG KevinGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinGG KevinGG merged commit ac12f52 into apache:master Mar 22, 2022
@victorplusc victorplusc deleted the use_default_dataproc_image branch March 22, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants