Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14163] Fix typo in single core per container logic. #17197

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

robertwb
Copy link
Contributor

Cherry-pick of #17195


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

R: @youngoli
CC: @chamikaramj @tvalentyn

@robertwb robertwb requested a review from youngoli March 28, 2022 20:46
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #17197 (05bdda7) into release-2.38.0 (24982cf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release-2.38.0   #17197      +/-   ##
==================================================
- Coverage           73.96%   73.96%   -0.01%     
==================================================
  Files                 672      672              
  Lines               88259    88259              
==================================================
- Hits                65280    65279       -1     
- Misses              21866    21867       +1     
  Partials             1113     1113              
Flag Coverage Δ
python 83.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apache_beam/runners/dataflow/internal/apiclient.py 77.27% <ø> (ø)
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 93.57% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24982cf...05bdda7. Read the comment docs.

@youngoli youngoli merged commit f9aef19 into apache:release-2.38.0 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants