Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-14236] Parquet IO support for list to conform with Apache Parqu… #17279

Merged
merged 1 commit into from Apr 8, 2022
Merged

[BEAM-14236] Parquet IO support for list to conform with Apache Parqu… #17279

merged 1 commit into from Apr 8, 2022

Conversation

Shiv22Wabale
Copy link

…et specification for Python SDK

Added flag driven apache parquet conform write for type list.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

3 similar comments
@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

@Shiv22Wabale
Copy link
Author

run python postcommit

@Shiv22Wabale
Copy link
Author

run python postcommit

@Shiv22Wabale
Copy link
Author

retest this please

@Shiv22Wabale Shiv22Wabale force-pushed the BEAM-14236 branch 2 times, most recently from af330c4 to fe6d088 Compare April 5, 2022 03:35
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited

Codecov Report

Merging #17279 (eca5ed8) into master (0262ee5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head eca5ed8 differs from pull request most recent head 2db2f6e. Consider uploading reports for the commit 2db2f6e to get more accurate results

@@            Coverage Diff             @@
##           master   #17279      +/-   ##
==========================================
- Coverage   74.15%   74.13%   -0.02%     
==========================================
  Files         676      676              
  Lines       89008    89009       +1     
==========================================
- Hits        66002    65990      -12     
- Misses      21859    21872      +13     
  Partials     1147     1147
Flag Coverage Δ
python 83.67% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/parquetio.py 96.11% <100.00%> (+0.02%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 77.53% <0.00%> (-2.18%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.25% <0.00%> (-0.81%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.90% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0262ee5...2db2f6e. Read the comment docs.

@github-actions github-actions bot added the docker label Apr 5, 2022
@github-actions github-actions bot removed the docker label Apr 5, 2022
@Shiv22Wabale
Copy link
Author

retest this please

@Shiv22Wabale Shiv22Wabale force-pushed the BEAM-14236 branch 3 times, most recently from 6e43c8e to 4cf85c3 Compare April 5, 2022 08:01
@github-actions github-actions bot added the java label Apr 5, 2022
@Shiv22Wabale Shiv22Wabale force-pushed the BEAM-14236 branch 2 times, most recently from 4721473 to 62bae55 Compare April 5, 2022 08:11
@github-actions github-actions bot removed the java label Apr 5, 2022
@Shiv22Wabale
Copy link
Author

retest this please

@Shiv22Wabale
Copy link
Author

retest this please

@Shiv22Wabale Shiv22Wabale marked this pull request as ready for review April 5, 2022 17:18
@Shiv22Wabale
Copy link
Author

R: @ihji

1 similar comment
@Shiv22Wabale
Copy link
Author

R: @ihji

@ihji
Copy link
Contributor

ihji commented Apr 5, 2022

@Shiv22Wabale You can use ./gradlew lint to check lint errors before uploading the PR.

@Shiv22Wabale Shiv22Wabale force-pushed the BEAM-14236 branch 2 times, most recently from 9a5a0fb to 20d177c Compare April 6, 2022 18:37
@Shiv22Wabale Shiv22Wabale marked this pull request as draft April 6, 2022 18:48
@Shiv22Wabale Shiv22Wabale force-pushed the BEAM-14236 branch 5 times, most recently from 9e9443c to db7d8a7 Compare April 6, 2022 20:49
@Shiv22Wabale Shiv22Wabale marked this pull request as ready for review April 6, 2022 22:02
@Shiv22Wabale
Copy link
Author

R: @ihji

ihji
ihji reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ihji ihji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great.

sdks/python/apache_beam/io/parquetio_test.py Show resolved Hide resolved
sdks/python/apache_beam/io/parquetio_test.py Show resolved Hide resolved
@Shiv22Wabale Shiv22Wabale requested a review from ihji April 7, 2022 00:47
@Shiv22Wabale
Copy link
Author

R: @ihji

@ihji ihji merged commit 5b0e92f into apache:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihji ihji ihji approved these changes

Assignees
No one assigned
Labels
io python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shiv22Wabale @asf-ci @ihji @lukecwik