Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14258] Fix metrics report dependency issue #17283

Merged
merged 1 commit into from Apr 5, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Apr 5, 2022

Right now, the metrics report generator is failing with error ERROR: File 'src/.test-infra/jenkins/metrics_report/beam-metrics_report.html' does not exist (see https://lists.apache.org/thread/d6r7plmxkh9s8z5d960rl0qhssq4r36w for an example). This should fix that error.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 5, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the infra label Apr 5, 2022
@damccorm damccorm changed the title Fix dependency issue causing failures Fix metrics report dependency issue Apr 5, 2022
@damccorm
Copy link
Contributor Author

damccorm commented Apr 5, 2022

Run Metrics Report

1 similar comment
@lostluck
Copy link
Contributor

lostluck commented Apr 5, 2022

Run Metrics Report

@damccorm
Copy link
Contributor Author

damccorm commented Apr 5, 2022

Looks like the report isn't getting triggered correctly from the PR - I'm not 100% sure why since @lostluck should be on the committer allow list - I did verify this locally though.

@damccorm damccorm marked this pull request as ready for review April 5, 2022 18:07
@damccorm
Copy link
Contributor Author

damccorm commented Apr 5, 2022

I moved this out of draft even though I can't get it to trigger since I was able to verify it locally, and the worst case scenario if this doesn't work is that it remains broken.

@ibzib ibzib changed the title Fix metrics report dependency issue [BEAM-14258] Fix metrics report dependency issue Apr 5, 2022
@damccorm
Copy link
Contributor Author

damccorm commented Apr 5, 2022

R: @emilymye

@ibzib
Copy link
Contributor

ibzib commented Apr 5, 2022

Run Metrics Report

@ibzib
Copy link
Contributor

ibzib commented Apr 5, 2022

jenkins isn't responding to gh comments, so I started a build through the Jenkins UI: https://ci-beam.apache.org/job/beam_Metrics_Report/84/console

@ibzib
Copy link
Contributor

ibzib commented Apr 5, 2022

hmm can't figure out how to pass a commit that jenkins recognizes. /shrug

LGTM

@ibzib ibzib merged commit 0c2ceff into apache:master Apr 5, 2022
@ibzib
Copy link
Contributor

ibzib commented Apr 5, 2022

It worked this time. Thanks Danny!

@damccorm
Copy link
Contributor Author

damccorm commented Apr 5, 2022

Thanks for the assist with running the job!

@damccorm damccorm deleted the users/damccorm/reportGenerator branch April 5, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants