New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14258] Fix metrics report dependency issue #17283
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Run Metrics Report |
1 similar comment
Run Metrics Report |
Looks like the report isn't getting triggered correctly from the PR - I'm not 100% sure why since @lostluck should be on the committer allow list - I did verify this locally though. |
I moved this out of draft even though I can't get it to trigger since I was able to verify it locally, and the worst case scenario if this doesn't work is that it remains broken. |
R: @emilymye |
Run Metrics Report |
jenkins isn't responding to gh comments, so I started a build through the Jenkins UI: https://ci-beam.apache.org/job/beam_Metrics_Report/84/console |
hmm can't figure out how to pass a commit that jenkins recognizes. /shrug LGTM |
It worked this time. Thanks Danny! |
Thanks for the assist with running the job! |
Right now, the metrics report generator is failing with error
ERROR: File 'src/.test-infra/jenkins/metrics_report/beam-metrics_report.html' does not exist
(see https://lists.apache.org/thread/d6r7plmxkh9s8z5d960rl0qhssq4r36w for an example). This should fix that error.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.