Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1223][Follow-up] Reduced visibility for Sum,Min,Max,Mean. #1731

Closed
wants to merge 1 commit into from
Closed

[BEAM-1223][Follow-up] Reduced visibility for Sum,Min,Max,Mean. #1731

wants to merge 1 commit into from

Conversation

staslev
Copy link
Contributor

@staslev staslev commented Jan 4, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

R: @lukecwik
I'm creating this PR following PR #1723 as discussed.

Let me know how it looks.

@staslev staslev changed the title [BEAM-1223][Followup] Reduced visibility for Sum,Min,Max,Mean. [BEAM-1223][Follow-up] Reduced visibility for Sum,Min,Max,Mean. Jan 4, 2017
@lukecwik
Copy link
Member

lukecwik commented Jan 4, 2017

retest this please

@asfbot
Copy link

asfbot commented Jan 4, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6405/
--none--

@lukecwik
Copy link
Member

lukecwik commented Jan 4, 2017

LGTM
I fixed up the Dataflow worker and now tests pass so merging.

@staslev
Copy link
Contributor Author

staslev commented Jan 4, 2017

Great, thanks for your help!

@asfgit asfgit closed this in 1e2f90c Jan 5, 2017
@staslev staslev deleted the BEAM-1223-follow-up branch February 11, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants