Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13866] Add miscellaneous exec unit tests #17363

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

jrmccluskey
Copy link
Contributor

Adds small unit tests. Adds checks for the discard node (all no-ops,) adds a session windowing case to the AssignWindows testing, and adds simple windowing and window mapping unmarshalling tests.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 13, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Apr 13, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the go label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #17363 (55ce567) into master (1d3d43b) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17363      +/-   ##
==========================================
+ Coverage   74.00%   74.06%   +0.06%     
==========================================
  Files         685      685              
  Lines       89720    89720              
==========================================
+ Hits        66393    66448      +55     
+ Misses      22167    22100      -67     
- Partials     1160     1172      +12     
Flag Coverage Δ
go 49.99% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/xlangx/registry.go 47.32% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/translate.go 14.50% <0.00%> (+7.53%) ⬆️
sdks/go/pkg/beam/core/runtime/exec/window.go 49.01% <0.00%> (+9.80%) ⬆️
sdks/go/pkg/beam/core/runtime/exec/discard.go 71.42% <0.00%> (+71.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3d43b...55ce567. Read the comment docs.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riteshghorse
Copy link
Contributor

R: @lostluck

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit c6972f4 into apache:master Apr 19, 2022
@jrmccluskey jrmccluskey deleted the execTesting branch April 20, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants