Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-14338] Update watermark unit tests to use time.Time.Equals() #17414

Merged
merged 1 commit into from Apr 20, 2022
Merged

[BEAM-14338] Update watermark unit tests to use time.Time.Equals() #17414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/go/pkg/beam/core/runtime/exec/sdf_test.go
View file
Open in desktop
Expand Up @@ -941,14 +941,14 @@ func TestAsSplittableUnit(t *testing.T) {
if got, ok := ow["output1"]; !ok {
t.Errorf("ProcessSizedElementsAndRestrictions(%v) has no watermark for ouptput1, want: %v",
test.in, test.want)
} else if got.AsTime() != test.want {
} else if !got.AsTime().Equal(test.want) {
t.Errorf("ProcessSizedElementsAndRestrictions(%v) has incorrect watermark for output1: got: %v, want: %v",
test.in, got.AsTime(), test.want)
}
if got, ok := ow["output2"]; !ok {
t.Errorf("ProcessSizedElementsAndRestrictions(%v) has no watermark for ouptput2, want: %v",
test.in, test.want)
} else if got.AsTime() != test.want {
} else if !got.AsTime().Equal(test.want) {
t.Errorf("ProcessSizedElementsAndRestrictions(%v) has incorrect watermark for output2: got: %v, want: %v",
test.in, got.AsTime(), test.want)
}
Expand Down