[BEAM-14344]: remove tracing from spannerio change streams #17422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes distributed tracing from spannerio change streams. The distributed tracing is not currently adding any value to the debugging or understanding of the process execution. We remove tracing here in order to simplify the code.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@thiagotnunes - please feel free to tag reviewers or ping them in future PRs. |
…stributed-tracing
|
Run Java PostCommit |
thiagotnunes
changed the title
|
PreCommit failures are unrelated to this PR |
|
Run Java PreCommit |
|
can you rebase the change? I'm starting to review it anyway |
…stributed-tracing
|
Run Java PostCommit |
|
LGTM. Failures unrelated. |
jrmccluskey
pushed a commit
to jrmccluskey/beam
that referenced
this pull request
May 3, 2022
…m spannerio change streams Removes distributed tracing from spannerio change streams. The distributed tracing is not currently adding any value to the debugging or understanding of the process execution. We remove tracing here in order to simplify the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes distributed tracing from spannerio change streams. The distributed tracing is not currently adding any value to the debugging or understanding of the process execution. We remove tracing here in order to simplify the code.