[BEAM-12164]: use the end timestamp for progress estimation in batch jobs #17443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Run Java PreCommit |
hengfengli
force-pushed
the
fix-backlog-size-for-batch
branch
from
9e8dab7
to
668a9bb
Compare
hengfengli
force-pushed
the
fix-backlog-size-for-batch
branch
from
668a9bb
to
f463df7
Compare
thiagotnunes
approved these changes
Apr 28, 2022
the streaming case.
|
Run Java PostCommit |
|
LGTM. Thanks! |
jrmccluskey
pushed a commit
to jrmccluskey/beam
that referenced
this pull request
May 3, 2022
…amp for progress estimation in batch jobs * [BEAM-12164]: use the end timestamp for progress estimation in batch jobs * Use Timestamp.now() to update the throughput estimator. * Fix the issue that range.getTo() should be Timestamp.MAX_VALUE for the streaming case. * Fix the unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of the progress calculation is:
endTimestamp - lastClaimedPosition.now() - lastClaimedPositionas the remaining work.This PR also includes a change to use Timestamp.now() for the throughput updates instead of using the event timestamp.