Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14357] Fix BigqueryFullResultStreamingMatcher unit test #17447

Merged
merged 2 commits into from Apr 26, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Apr 22, 2022

  • patch bigquery.Client in test class

Please add a meaningful description for your change here

The original patch for '_query_with_retry' actually did not work. BigqueryMatcher._query_with_retry still get called. The test passed because timeout checking passed before the first call of this method. In local machine that runs fast enough, it may still make actual bigquery request and fail.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 22, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Apr 22, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 22, 2022

Can one of the admins verify this patch?

@Abacn
Copy link
Contributor Author

Abacn commented Apr 22, 2022

R: @pabloem

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #17447 (ef89023) into master (1540b9d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17447      +/-   ##
==========================================
- Coverage   73.91%   73.90%   -0.01%     
==========================================
  Files         687      687              
  Lines       90334    90334              
==========================================
- Hits        66768    66763       -5     
- Misses      22382    22387       +5     
  Partials     1184     1184              
Flag Coverage Δ
python 83.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 90.24% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 77.53% <0.00%> (-2.18%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.18% <0.00%> (-0.31%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.26% <0.00%> (-0.13%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.06% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1540b9d...ef89023. Read the comment docs.

@Abacn
Copy link
Contributor Author

Abacn commented Apr 26, 2022

A github action fails due to BEAM-14367 not relevant to this change.

@pabloem
Copy link
Member

pabloem commented Apr 26, 2022

LGTM!

@pabloem pabloem merged commit 8ecd513 into apache:master Apr 26, 2022
@Abacn Abacn deleted the matchertestpatch branch April 26, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants