[BEAM-13590] Minor deprecated warning fix #17453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix abc import * Also fix pyarrow deprecated parameter name
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17453 +/- ##
==========================================
- Coverage 73.93% 73.92% -0.01%
==========================================
Files 689 689
Lines 90397 90397
==========================================
- Hits 66834 66828 -6
- Misses 22379 22385 +6
Partials 1184 1184
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
R: @tvalentyn |
1 similar comment
|
R: @tvalentyn |
tvalentyn
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix abc import
Also fix pyarrow deprecated parameter name
Please add a meaningful description for your change here
Found two warnings in python unit test related to deprecated code:
apache_beam/runners/direct/transform_evaluator.py:1029
/Users/yathu/beam/sdks/python/apache_beam/runners/direct/transform_evaluator.py:1029: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 (Note: 3.10) it will stop working
isinstance(element.value, collections.Iterable) and
apache_beam/io/parquetio_test.py:426
/Users/yathu/beam/sdks/python/apache_beam/io/parquetio_test.py:426: FutureWarning: The parameter chunksize is deprecated for pyarrow.Table.to_batches as of 0.15, please use the parameter max_chunksize instead
pa.Table.from_batches([batch]) for batch in self._records_as_arrow(
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.