-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14173] Fix Go Loadtests on Dataflow & partial fix for Flink #17554
Conversation
Run Load Tests Go CoGBK Flink Batch |
Run Load Tests Go Combine Flink Batch |
Run Load Tests Go GBK Flink Batch |
Run Load Tests Go ParDo Flink Batch |
Run Load Tests Go SideInput Flink Batch |
Codecov Report
@@ Coverage Diff @@
## master #17554 +/- ##
=======================================
Coverage 73.88% 73.88%
=======================================
Files 691 691
Lines 91543 91543
=======================================
Hits 67641 67641
Misses 22669 22669
Partials 1233 1233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks like the whole pipeline initialization set up has bit-rot while this has been broken. Likely easier to fix the Dataflow tests & their missing SDK image first. |
Run Load Tests Go SideInput Flink Batch |
Run Load Tests Go SideInput Dataflow Batch suite |
Run Load Tests Go SideInput Dataflow Batch |
Run Load Tests Go SideInput Dataflow Batch |
Run Seed Job |
Run Load Tests Go SideInput Dataflow Batch |
Run Load Tests Go SideInput Dataflow Batch |
Run Load Tests Go GBK Dataflow Batch |
Run Load Tests Go CoGBK Dataflow Batch |
Run Load Tests Go Combine Dataflow Batch |
Run Load Tests Go GBK Dataflow Batch |
Run Load Tests Go ParDo Dataflow Batch |
Run Seed Job Standalone |
Run Seed Job |
Run Load Tests Go ParDo Dataflow Batch |
Run Load Tests Go GBK Dataflow Batch |
Run Load Tests Go Combine Dataflow Batch |
Run Load Tests Go CoGBK Dataflow Batch |
Run Load Tests Go SideInput Dataflow Batch |
1 similar comment
Run Load Tests Go SideInput Dataflow Batch |
Run Load Tests Go SideInput Dataflow Batch |
Run Load Tests Go GBK Dataflow Batch |
OK, leaving at demonstrating two of them. The runs can collide and the jobs are all passing, if not represented by the interrupted jenkins runs. A Seed job would need to be run, before retyring to ensure the local changes are reflected by the runs. |
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Thanks! |
Makes a minor breaking change to the SourceConfigs for the synthetic.Source testing io. The
int
fields are nowint64
to become known types. In Goint
is architecture dependent.Flink & the Java runners don't appear to like having Schemas with "unknown logical types", which significantly reduces the value of logical types to "something known across all SDKs". Especially since in this instance when no runner side manipulation is required of them.
Dataflow loadtests were failing because the default container wasn't being found, but specifying the automatically built and pushed latest container like Python does resolves the issue.
PR also fixes an inconsistency in the jenkins README & display of one of the loadtest suites.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.