Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14173] Fix Go Loadtests on Dataflow & partial fix for Flink #17554

Merged
merged 7 commits into from
May 5, 2022

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented May 4, 2022

Makes a minor breaking change to the SourceConfigs for the synthetic.Source testing io. The int fields are now int64 to become known types. In Go int is architecture dependent.

Flink & the Java runners don't appear to like having Schemas with "unknown logical types", which significantly reduces the value of logical types to "something known across all SDKs". Especially since in this instance when no runner side manipulation is required of them.

Dataflow loadtests were failing because the default container wasn't being found, but specifying the automatically built and pushed latest container like Python does resolves the issue.

PR also fixes an inconsistency in the jenkins README & display of one of the loadtest suites.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@lostluck
Copy link
Contributor Author

lostluck commented May 4, 2022

Run Load Tests Go CoGBK Flink Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 4, 2022

Run Load Tests Go Combine Flink Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 4, 2022

Run Load Tests Go GBK Flink Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 4, 2022

Run Load Tests Go ParDo Flink Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 4, 2022

Run Load Tests Go SideInput Flink Batch

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #17554 (a9e5b39) into master (017f846) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17554   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files         691      691           
  Lines       91543    91543           
=======================================
  Hits        67641    67641           
  Misses      22669    22669           
  Partials     1233     1233           
Flag Coverage Δ
go 50.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/io/synthetic/source.go 64.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017f846...a9e5b39. Read the comment docs.

@lostluck
Copy link
Contributor Author

lostluck commented May 4, 2022

Looks like the whole pipeline initialization set up has bit-rot while this has been broken. Likely easier to fix the Dataflow tests & their missing SDK image first.

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Flink Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch suite

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Seed Job

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

@github-actions github-actions bot removed the runners label May 5, 2022
@lostluck lostluck changed the title [BEAM-14173] Fix Go loadtests on Flink. [BEAM-14173] Fix Go Loadtests on Dataflow & partial fix for Flink May 5, 2022
@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go GBK Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go CoGBK Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go Combine Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go GBK Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go ParDo Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Seed Job Standalone

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Seed Job

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go ParDo Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go GBK Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go Combine Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go CoGBK Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

1 similar comment
@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go SideInput Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Run Load Tests Go GBK Dataflow Batch

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

OK, leaving at demonstrating two of them. The runs can collide and the jobs are all passing, if not represented by the interrupted jenkins runs.

A Seed job would need to be run, before retyring to ensure the local changes are reflected by the runs.

@lostluck lostluck marked this pull request as ready for review May 5, 2022 06:14
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor Author

lostluck commented May 5, 2022

Thanks!

@lostluck lostluck merged commit 0af670d into apache:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants