Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14146] Python Streaming job failing to drain with BigQueryIO write errors #17566

Merged
merged 1 commit into from May 6, 2022

Conversation

ihji
Copy link
Contributor

@ihji ihji commented May 5, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ihji
Copy link
Contributor Author

ihji commented May 5, 2022

R: @pabloem
CC: @chunyang @chamikaramj

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #17566 (68e2a10) into master (1215973) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #17566      +/-   ##
==========================================
+ Coverage   73.89%   74.02%   +0.13%     
==========================================
  Files         691      691              
  Lines       91543    92054     +511     
==========================================
+ Hits        67642    68147     +505     
- Misses      22668    22674       +6     
  Partials     1233     1233              
Flag Coverage Δ
python 83.80% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py 83.15% <100.00%> (+0.17%) ⬆️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 93.08% <0.00%> (+0.64%) ⬆️
...apache_beam/runners/portability/portable_runner.py 77.31% <0.00%> (+1.71%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 91.45% <0.00%> (+2.54%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 91.09% <0.00%> (+3.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1215973...68e2a10. Read the comment docs.

@pabloem
Copy link
Member

pabloem commented May 6, 2022

LGTM

@pabloem pabloem merged commit a0684f5 into apache:master May 6, 2022
y1chi pushed a commit to y1chi/beam that referenced this pull request May 9, 2022
…b failing to drain with BigQueryIO write errors

[BEAM-14146] Python Streaming job failing to drain with BigQueryIO write errors
y1chi added a commit that referenced this pull request May 10, 2022
…ling to drain with BigQueryIO write errors (#17595)

[BEAM-14146] Python Streaming job failing to drain with BigQueryIO write errors

Co-authored-by: Pablo <pabloem@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants