Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eslint and lint configuration to TypeScript SDK #17676

Merged
merged 3 commits into from
May 16, 2022
Merged

Adding eslint and lint configuration to TypeScript SDK #17676

merged 3 commits into from
May 16, 2022

Conversation

pcoet
Copy link
Collaborator

@pcoet pcoet commented May 16, 2022

Please add a meaningful description for your change here

@robertwb @kerrydc

Added eslint and TypeScript linting config to the TypeScript SDK. You can run it with npm run lint, but it's not integrated with the build step, so won't fail the build -- just informational. There are currently 4000+ problems, but a lot of them are low-hanging fruit: unused values, implicity any, or async declarations that don't await anything. I'd like to tidy up some...


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 16, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 16, 2022

Can one of the admins verify this patch?

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Would definitely welcome the code getting cleaned up!

sdks/typescript/package.json Outdated Show resolved Hide resolved
@robertwb robertwb merged commit 03c3c36 into apache:master May 16, 2022
@pcoet pcoet deleted the linter branch May 16, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants