Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification on Filter transform's input function to pydoc. #17704

Merged
merged 1 commit into from
May 23, 2022

Conversation

tomstepp
Copy link
Contributor

@tomstepp tomstepp commented May 18, 2022

It was difficult to understand how to implement a function to pass to the Filter transform. I added a useful comment that was found in "https://beam.apache.org/documentation/transforms/python/elementwise/filter/".


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

It was difficult to understand how to implement a function to pass to the Filter transform. I added a useful comment that was found in "https://beam.apache.org/documentation/transforms/python/elementwise/filter/".
@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

3 similar comments
@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #17704 (63ce79d) into master (6774b74) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17704      +/-   ##
==========================================
- Coverage   74.00%   73.99%   -0.02%     
==========================================
  Files         695      695              
  Lines       91798    91798              
==========================================
- Hits        67938    67922      -16     
- Misses      22612    22628      +16     
  Partials     1248     1248              
Flag Coverage Δ
python 83.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 92.30% <ø> (ø)
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <0.00%> (-5.34%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 89.20% <0.00%> (-1.44%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.43% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6774b74...63ce79d. Read the comment docs.

@tomstepp
Copy link
Contributor Author

tomstepp commented May 20, 2022

R: @tvalentyn

@tomstepp
Copy link
Contributor Author

Valentyn - I'm not sure who to add as reviewer, can you please take a look or help me find correct reviewer?

@tvalentyn
Copy link
Contributor

Thank you!

@tvalentyn tvalentyn merged commit 3cddfaf into apache:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants