Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11578] Fix TypeError in dataflow_metrics has 0 distribution sum #17706

Merged
merged 1 commit into from
May 23, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 18, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@Abacn
Copy link
Contributor Author

Abacn commented May 18, 2022

R: @y1chi

Copy link
Contributor

@y1chi y1chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn
Copy link
Contributor Author

Abacn commented May 23, 2022

Run Python PreCommit

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #17706 (d18c8b5) into master (da4fcad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17706   +/-   ##
=======================================
  Coverage   73.99%   73.99%           
=======================================
  Files         695      695           
  Lines       91798    91798           
=======================================
+ Hits        67926    67928    +2     
+ Misses      22624    22622    -2     
  Partials     1248     1248           
Flag Coverage Δ
python 83.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/apache_beam/runners/dataflow/dataflow_metrics.py 74.83% <100.00%> (ø)
sdks/python/apache_beam/io/gcp/bigquery.py 64.99% <0.00%> (-0.12%) ⬇️
sdks/python/apache_beam/transforms/core.py 92.30% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.55% <0.00%> (+0.12%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4fcad...d18c8b5. Read the comment docs.

@y1chi y1chi merged commit ac24771 into apache:master May 23, 2022
@Abacn Abacn deleted the fix0sum branch May 23, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants