Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14487] Make drain & update terminal states. #17710

Merged
merged 3 commits into from May 19, 2022

Conversation

lostluck
Copy link
Contributor

Add drained and updated to states the Dataflow runner package is aware of in the WaitForCompletion loop, and log and terminate appropriately. Make the handling more consistent between states.

Tested manually against Dataflow.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #17710 (8724957) into master (6774b74) will increase coverage by 0.01%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master   #17710      +/-   ##
==========================================
+ Coverage   74.00%   74.01%   +0.01%     
==========================================
  Files         695      695              
  Lines       91798    91815      +17     
==========================================
+ Hits        67938    67960      +22     
+ Misses      22612    22607       -5     
  Partials     1248     1248              
Flag Coverage Δ
go 50.46% <76.92%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go 22.84% <76.92%> (+6.57%) ⬆️
...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go 75.70% <0.00%> (ø)
sdks/go/pkg/beam/runners/dataflow/dataflow.go 53.64% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6774b74...8724957. Read the comment docs.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/runners/dataflow/dataflowlib/job_test.go Outdated Show resolved Hide resolved
lostluck and others added 2 commits May 19, 2022 13:26
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
@lostluck
Copy link
Contributor Author

SDK can express little a joy, as a treat.

@lostluck lostluck merged commit de497f7 into apache:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants