[BEAM-14494] Tag RC container version to have form ${RELEASE}rc${RC_NUM} #17725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tvalentyn |
tvalentyn
reviewed
May 20, 2022
.github/workflows/build_wheels.yml
Outdated
| @@ -128,7 +128,7 @@ jobs: | |||
| run: | | |||
| RELEASE_VERSION=${{ steps.get_rc_version.outputs.RELEASE_VERSION }} | |||
| RC_NUM=${{ steps.get_rc_version.outputs.RC_NUM }} | |||
| sed -i -e "s/${RELEASE_VERSION}/${RELEASE_VERSION}rc${RC_NUM}/g" apache_beam/version.py | |||
| sed -i -e "s/${RELEASE_VERSION}/${RELEASE_VERSION}_rc${RC_NUM}/g" apache_beam/version.py | |||
There was a problem hiding this comment.
I think we should fix it the other way around, as the release version follows an established pattern: https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#standards-compliance-for-interoperability
y1chi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #17725 +/- ##
==========================================
- Coverage 74.00% 73.99% -0.01%
==========================================
Files 695 695
Lines 91798 91798
==========================================
- Hits 67936 67927 -9
- Misses 22614 22623 +9
Partials 1248 1248
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM |
|
Thanks. This should work well for Python, not sure about other SDKs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.