Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'NoneType' object has no attribute error in bigquery_test.py #17746

Merged
merged 1 commit into from
May 24, 2022

Conversation

ihji
Copy link
Contributor

@ihji ihji commented May 24, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ihji
Copy link
Contributor Author

ihji commented May 24, 2022

R: @tvalentyn

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #17746 (ca7a80f) into master (2d57753) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17746      +/-   ##
==========================================
- Coverage   73.98%   73.98%   -0.01%     
==========================================
  Files         695      695              
  Lines       91774    91798      +24     
==========================================
+ Hits        67898    67914      +16     
- Misses      22627    22635       +8     
  Partials     1249     1249              
Flag Coverage Δ
python 83.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <0.00%> (-7.71%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
sdks/python/apache_beam/io/gcp/gcsio.py 92.26% <0.00%> (ø)
sdks/python/apache_beam/transforms/core.py 92.30% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.55% <0.00%> (ø)
...dks/python/apache_beam/options/pipeline_options.py 94.93% <0.00%> (+0.01%) ⬆️
...apache_beam/runners/dataflow/internal/apiclient.py 77.39% <0.00%> (+0.03%) ⬆️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 88.65% <0.00%> (+0.41%) ⬆️
sdks/python/apache_beam/coders/typecoders.py 93.67% <0.00%> (+1.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d57753...ca7a80f. Read the comment docs.

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@ihji ihji merged commit d8a67a9 into apache:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants