Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14511] Growable Tracker for Go SDK #17754

Merged
merged 13 commits into from Jun 2, 2022
Merged

Conversation

riteshghorse
Copy link
Contributor

Added a growable tracker for Go SDK. This is useful in streaming use cases of SDFs.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

4 similar comments
@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 25, 2022

Can one of the admins verify this patch?

@riteshghorse
Copy link
Contributor Author

riteshghorse commented May 25, 2022

Run GoPortable PostCommit

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #17754 (3f8e8da) into master (23aeca4) will increase coverage by 0.00%.
The diff coverage is 76.27%.

@@           Coverage Diff           @@
##           master   #17754   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         697      697           
  Lines       91927    91980   +53     
=======================================
+ Hits        68091    68136   +45     
- Misses      22591    22595    +4     
- Partials     1245     1249    +4     
Flag Coverage Δ
go 50.82% <76.27%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go 80.62% <76.27%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23aeca4...3f8e8da. Read the comment docs.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Contributor Author

R: @damccorm @jrmccluskey

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@riteshghorse
Copy link
Contributor Author

CC: @youngoli

@riteshghorse
Copy link
Contributor Author

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are good, but we can make them better.

@riteshghorse
Copy link
Contributor Author

Made the changes, PTAL.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like GetProgress isn't implemented correctly. If there's a good reason for it, add a comment, otherwise, we should be closer to the java implementation. As it stands, there will be effectively no progress until the range becomes bounded.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit bf4f641 into apache:master Jun 2, 2022
@riteshghorse riteshghorse deleted the gtracker branch June 27, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants