New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14519] Add website page for Go dependencies #17766
[BEAM-14519] Add website page for Go dependencies #17766
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
R: @lostluck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like the idea of linking to:
https://deps.dev/go/github.com%2Fapache%2Fbeam%2Fsdks%2Fv2/
Which will list all versions of the module, and include the various scorecards and things automatically, and then the dependencies are also visible right there.
website/www/site/content/en/documentation/sdks/go-dependencies.md
Outdated
Show resolved
Hide resolved
Unless we plan on staying on top of those warnings, I'm not sure I want to direct users that way. Security conscious customers will mostly already have a way of assessing their dependencies (or will find one), but most others will probably navigate to that page, be alarmed, and not have the context to tell if any of these dependencies actually matter to Beam. If we're planning on getting green on that page and staying green then I care less (but I don't really see that being a high priority) |
Fair points. I may go ahead and try to clear them, but there's no need to highlight them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Right now Java and Python have dependency pages, but Go does not. This closes that gap.
✨ RENDERED ✨
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.