Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14519] Add website page for Go dependencies #17766

Merged
merged 4 commits into from May 26, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented May 26, 2022

Right now Java and Python have dependency pages, but Go does not. This closes that gap.

RENDERED


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 26, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented May 26, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 26, 2022

Can one of the admins verify this patch?

@damccorm
Copy link
Contributor Author

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like the idea of linking to:

https://deps.dev/go/github.com%2Fapache%2Fbeam%2Fsdks%2Fv2/

Which will list all versions of the module, and include the various scorecards and things automatically, and then the dependencies are also visible right there.

@damccorm
Copy link
Contributor Author

I also like the idea of linking to:

https://deps.dev/go/github.com%2Fapache%2Fbeam%2Fsdks%2Fv2/

Which will list all versions of the module, and include the various scorecards and things automatically, and then the dependencies are also visible right there.

Unless we plan on staying on top of those warnings, I'm not sure I want to direct users that way. Security conscious customers will mostly already have a way of assessing their dependencies (or will find one), but most others will probably navigate to that page, be alarmed, and not have the context to tell if any of these dependencies actually matter to Beam.

If we're planning on getting green on that page and staying green then I care less (but I don't really see that being a high priority)

@lostluck
Copy link
Contributor

Fair points. I may go ahead and try to clear them, but there's no need to highlight them.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit ff2ac0a into apache:master May 26, 2022
@damccorm damccorm deleted the users/damccorm/go-dependency-docs branch May 27, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants