-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NonType error when importing google.api_core fails #17774
Conversation
R: @ahmedabu98 |
Codecov Report
@@ Coverage Diff @@
## master #17774 +/- ##
==========================================
- Coverage 74.01% 74.00% -0.01%
==========================================
Files 695 695
Lines 91798 91806 +8
==========================================
+ Hits 67941 67942 +1
- Misses 22611 22618 +7
Partials 1246 1246
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
error_reason='internalError'), | ||
param( | ||
exception_type=exceptions.InternalServerError, | ||
exception_type=exceptions.InternalServerError if exceptions else None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these tests still run if empty params are passed in? Would it be more optimal to skip them entirely? Something like this in the beginning of each affected test:
if exceptions is None:
self.skipTest("Import fail: google.api_core")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's already there:
HttpError is None or exceptions is None, |
this pr fixes the error thrown even when the test is marked as skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. This LGTM then.
skipIf doesn't work for parameterized arguments since it's executed first.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.