Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Javadoc aggregateJavadoc task if there's an error #17801

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

y1chi
Copy link
Contributor

@y1chi y1chi commented Jun 1, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Jun 1, 2022
@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

R: @TheNeuralBit

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a precommit that will catch changes that break this?

@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

I think beam_PostCommit_Javadoc does that

@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

Run Javadoc PostCommit

1 similar comment
@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

Run Javadoc PostCommit

@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

Run Java PreCommit

@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

Run Java_Examples_Dataflow_Java17 PreCommit

@y1chi
Copy link
Contributor Author

y1chi commented Jun 1, 2022

Run Java_Examples_Dataflow_Java11 PreCommit

@y1chi y1chi merged commit 36d0455 into apache:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants