[BEAM-10976] Fix bug with bundle finalization on SDFs (and a small doc bug)

[damccorm]

Right now, running an SDF with a BundleFinalizer blows up with errors: panic: runtime error: invalid memory address or nil pointer dereference goroutine 100. It was working fine on non-SDFs.

I was able to repro - failing pipeline:

And after the fix the same pipeline succeeds:

I also verified that non-SDFs still don't have any issues

This also fixes a doc bug with the programming guide which had the parameters misordered: ✨ RENDERED ✨

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[asf-ci]

Can one of the admins verify this patch?

[asf-ci]

Can one of the admins verify this patch?

[asf-ci]

Can one of the admins verify this patch?

[damccorm]

Run Website_Stage_GCS PreCommit

[codecov]

Codecov Report

Merging #17811 (04b24dc) into master (36d0455) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17811   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         697      697           
  Lines       91927    91986   +59     
=======================================
+ Hits        68091    68142   +51     
- Misses      22591    22595    +4     
- Partials     1245     1249    +4     

Flag	Coverage Δ
go	50.83% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/fn.go	69.55% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/pardo.go	59.43% <100.00%> (+0.32%)	⬆️
sdks/go/pkg/beam/core/runtime/exec/plan.go	46.97% <100.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/sdf.go	70.84% <100.00%> (+0.23%)	⬆️
...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go	80.62% <0.00%> (+2.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d0455...04b24dc. Read the comment docs.

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @youngoli for label go.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[lostluck]

LGTM Thanks!