Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14406] Drain test for SDF truncation in Go SDK #17814

Merged
merged 4 commits into from Jun 9, 2022

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Jun 2, 2022

Adds a drain test for SDF truncation during drain added in #17432 . It runs only on Dataflow as of now but it is filtered from it because drain has to be triggered manually from the UI.

Screenshots of truncation in action:
image
image

closes #21681


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 2, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Jun 2, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 2, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the go label Jun 2, 2022
@riteshghorse riteshghorse changed the title Beam 14406 [BEAM-14406] Drain test for SDF truncation in Go SDK Jun 2, 2022
@riteshghorse
Copy link
Contributor Author

Run GoPortable PostCommit

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

R: @youngoli for final approval

@riteshghorse
Copy link
Contributor Author

R: @lostluck

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@riteshghorse riteshghorse changed the title [BEAM-14406] Drain test for SDF truncation in Go SDK [BEAM-14406] Drain test for SDF truncation in Go SDK, closes #21681 Jun 7, 2022
@riteshghorse riteshghorse changed the title [BEAM-14406] Drain test for SDF truncation in Go SDK, closes #21681 [BEAM-14406] Drain test for SDF truncation in Go SDK Jun 7, 2022
@@ -154,6 +164,8 @@ var dataflowFilters = []string{
// Dataflow does not automatically terminate the TestCheckpointing pipeline when
// complete.
"TestCheckpointing",
// Dataflow does not drain jobs by itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note that we can add a programatic bit that could drain the job automatically, in particular for this test. But that's a fair amount of work, since we'd need to provide access to the JobID, and the Dataflow client, via some kind of "running job" wrapper.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit d786293 into apache:master Jun 9, 2022
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration testing of Pipeline drain in Go SDK
4 participants