Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14556] Honor the formatter installed on the root handler. #17820

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Jun 2, 2022

This allows for an MDC to be integrated and/or other options when formatting the message.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This allows for an MDC to be integrated and/or other options.
@lukecwik
Copy link
Member Author

lukecwik commented Jun 2, 2022

R: @TheNeuralBit @kileys

@lukecwik
Copy link
Member Author

lukecwik commented Jun 3, 2022

Run Java PreCommit

1 similar comment
@lukecwik
Copy link
Member Author

lukecwik commented Jun 3, 2022

Run Java PreCommit

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document somewhere that the way for users to interact with this is a JvmInitializer?

@lukecwik
Copy link
Member Author

lukecwik commented Jun 3, 2022

Run Java PreCommit

2 similar comments
@lukecwik
Copy link
Member Author

lukecwik commented Jun 3, 2022

Run Java PreCommit

@lukecwik
Copy link
Member Author

lukecwik commented Jun 4, 2022

Run Java PreCommit

@lukecwik lukecwik merged commit 4dce7b8 into apache:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants